Clique Block Choice Rule #3436
Merged
Clique Block Choice Rule #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
|
@karalabe can I get your take? |
MicahZoltu
approved these changes
Apr 2, 2021
|
|
||
| ## Motivation | ||
|
|
||
| Recently (5 March 2021) there were a couple of deadlocks in the Goerli multi-client Clique network. |
There was a problem hiding this comment.
Suggested change
| Recently (5 March 2021) there were a couple of deadlocks in the Goerli multi-client Clique network. | |
| There has been more than one deadlock in the Goerli multi-client Clique network. |
| the **smallest** value. | ||
|
|
||
| ``` | ||
| (Hn - Vi) % Vt |
There was a problem hiding this comment.
Recommend human readable variable names rather than single or double letter names:
Suggested change
| (Hn - Vi) % Vt | |
| (header_number - validator_index) % validator_count |
|
|
||
| ## Reference Implementation | ||
|
|
||
| Implementation in Hyperledger Besu: https://github.com/hyperledger/besu/pull/2084 |
There was a problem hiding this comment.
Reference implementation should either be inline, in ../assets/eip-3436 or the entire section can be left out (it is optional). EIPs are not an appropriate place for lists of things or external links to third party repositories.
phi-line
pushed a commit
to phi-line/EIPs
that referenced
this pull request
Apr 29, 2021
Add a four step block rule to Clique that should reduce block production deadlocks
PhABC
pushed a commit
to PhABC/EIPs
that referenced
this pull request
Jan 25, 2022
Add a four step block rule to Clique that should reduce block production deadlocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fork choice rules to clique aimed to prevent deadlocks.
Signed-off-by: Danno Ferrin danno.ferrin@gmail.com